feat: add support for exit zero on sigterm #1870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
If you'll sign the CLA, we can get this merged. |
enocom
changed the title
|
Hi @enocom, just to let you know that I have signed the CLA. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to add a new argument
exit-zero-on-sigtermto exit with 0 exit code whenSIGTERMis received.This is needed because since v2 cloud-sql-proxy started returning 143 code which is causing problems with Airflow KPO and other applications on k8s.
When cloud-sql-proxy runs in the same pod with other containers and when the main container exits successfully k8s sends
SIGTERMto cloud-sql-proxy. Then cloud-sql-proxy is returning 143 in this scenario, and airflow KPO thinks that there was an error and marks the job as failed.Fixes #1803.